-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2E improvements #6369
Merged
Merged
E2E improvements #6369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunobar79
commented
Dec 21, 2024
Comment on lines
+470
to
+486
console.log('getting provider'); | ||
const provider = getProvider(); | ||
// Hardhat account 0 that has 10000 ETH | ||
console.log('got provider', provider); | ||
// anvil account 0 that has 10000 ETH | ||
const wallet = new Wallet('0xac0974bec39a17e36ba4a6b4d238ff944bacb478cbed5efcae784d7bf4f2ff80', provider); | ||
console.log('got wallet', wallet); | ||
// Sending 20 ETH so we have enough to pay the tx fees even when the gas is too high | ||
console.log('sending eth'); | ||
await wallet.sendTransaction({ | ||
to: TESTING_WALLET, | ||
value: parseEther('20'), | ||
}); | ||
console.log('sent eth'); | ||
await delayTime('long'); | ||
console.log('checking balance'); | ||
const balance = await provider.getBalance(TESTING_WALLET); | ||
console.log('got balance', formatEther(balance)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's keep this log cause this part breaks often
derHowie
approved these changes
Dec 21, 2024
walmat
approved these changes
Dec 22, 2024
brunobar79
commented
Dec 23, 2024
derHowie
pushed a commit
that referenced
this pull request
Dec 23, 2024
* fix broken testID for backups and condiiton that prevents manually backed up wallets from being marked as backed up * fix path for serial and parallel * E2E improvements (#6369) * goodbye hardhat => hello anvil * replace usage of IS_TESTING in favor of IS_TEST * fix detox config * more refactor * anvil already installed in CI machines * fix anvil shutdown * retry per file so we can handle anvil separately * fix inverse logic --------- Co-authored-by: Bruno Barbieri <[email protected]> Co-authored-by: Bruno Barbieri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-####
What changed (plus any additional context for devs)
IS_TESTING
in favor ofIS_TEST
Screen recordings / screenshots
Before ~ 21min
Now ~ 15min
What to test
e2e should pass