Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E improvements #6369

Merged
merged 8 commits into from
Dec 23, 2024
Merged

Conversation

brunobar79
Copy link
Member

@brunobar79 brunobar79 commented Dec 21, 2024

Fixes APP-####

What changed (plus any additional context for devs)

  • Replace Hardhat in favor of Anvil
  • Replace usage of IS_TESTING in favor of IS_TEST
  • Fix the detox config to actually run the correct tests for serial & parallel. This wasn't working and tests were running on the wrong queue.
  • Update the script with more efficient retry logic so it only runs what failed instead of the entire suite
  • Run anvil separately so we can see the logs that are actually useful during the job execution

Screen recordings / screenshots

Before ~ 21min

Screenshot 2024-12-21 at 8 02 51 PM

Now ~ 15min
Screenshot 2024-12-21 at 8 03 00 PM

What to test

e2e should pass

Comment on lines +470 to +486
console.log('getting provider');
const provider = getProvider();
// Hardhat account 0 that has 10000 ETH
console.log('got provider', provider);
// anvil account 0 that has 10000 ETH
const wallet = new Wallet('0xac0974bec39a17e36ba4a6b4d238ff944bacb478cbed5efcae784d7bf4f2ff80', provider);
console.log('got wallet', wallet);
// Sending 20 ETH so we have enough to pay the tx fees even when the gas is too high
console.log('sending eth');
await wallet.sendTransaction({
to: TESTING_WALLET,
value: parseEther('20'),
});
console.log('sent eth');
await delayTime('long');
console.log('checking balance');
const balance = await provider.getBalance(TESTING_WALLET);
console.log('got balance', formatEther(balance));
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's keep this log cause this part breaks often

Copy link

socket-security bot commented Dec 21, 2024

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/@chainsafe/[email protected], npm/@chainsafe/[email protected], npm/@chainsafe/[email protected], npm/@fastify/[email protected], npm/@noble/[email protected], npm/@nomicfoundation/[email protected], npm/@nomicfoundation/[email protected], npm/@nomicfoundation/[email protected], npm/@nomicfoundation/[email protected], npm/@nomicfoundation/[email protected], npm/@nomicfoundation/[email protected], npm/@nomicfoundation/[email protected], npm/@nomicfoundation/[email protected], npm/@nomicfoundation/[email protected], npm/@nomicfoundation/[email protected], npm/@nomicfoundation/[email protected], npm/@nomicfoundation/[email protected], npm/@nomicfoundation/[email protected], npm/@nomicfoundation/[email protected], npm/@nomicfoundation/[email protected], npm/@nomicfoundation/[email protected], npm/@nomicfoundation/[email protected], npm/@nomicfoundation/[email protected], npm/@nomicfoundation/[email protected], npm/@nomiclabs/[email protected], npm/@nomiclabs/[email protected], npm/@sentry/[email protected], npm/@sentry/[email protected], npm/@sentry/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

@brunobar79 brunobar79 changed the title Switch to Anvil E2E improvements Dec 21, 2024
@brunobar79
Copy link
Member Author

Launch in simulator or device for df5ee7a

@brunobar79
Copy link
Member Author

Launch in simulator or device for ee42ebc

@brunobar79
Copy link
Member Author

Launch in simulator or device for 316a81e

@brunobar79 brunobar79 merged commit e45164a into @matthew/fix-backups-e2e Dec 23, 2024
6 checks passed
@brunobar79 brunobar79 deleted the @bruno/switch-to-anvil branch December 23, 2024 15:18
derHowie pushed a commit that referenced this pull request Dec 23, 2024
* fix broken testID for backups and condiiton that prevents manually backed up wallets from being marked as backed up

* fix path for serial and parallel

* E2E improvements (#6369)

* goodbye hardhat => hello anvil

* replace usage of IS_TESTING in favor of IS_TEST

* fix detox config

* more refactor

* anvil already installed in CI machines

* fix anvil shutdown

* retry per file so we can handle anvil separately

* fix inverse logic

---------

Co-authored-by: Bruno Barbieri <[email protected]>
Co-authored-by: Bruno Barbieri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants